mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Date Fri, 10 Jan 2020 13:08:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/#review219212
-----------------------------------------------------------


Fix it, then Ship it!




Forgot to attach these comments to my latest FixIt/ShipIt.


src/slave/flags.cpp
Lines 991 (patched)
<https://reviews.apache.org/r/71816/#comment307323>

    Can you put the e.g., single quotes?



src/slave/flags.cpp
Lines 995 (patched)
<https://reviews.apache.org/r/71816/#comment307322>

    Use the constant introduced elsewhere here as well.



src/slave/slave.cpp
Lines 11095 (patched)
<https://reviews.apache.org/r/71816/#comment307324>

    Ditto.


- Benjamin Bannier


On Jan. 10, 2020, 2:43 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71816/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2020, 2:43 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-10035
>     https://issues.apache.org/jira/browse/MESOS-10035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added two new flags 'http_executor_domain_sockets' and
> 'domain_socket_location' to the agent, along with minimal
> logic to pass the relevant values on to executors.
> 
> They are used to control whether the agent should
> provide a domain socket to HTTP executors and the
> location of the socket on the host filesystem, respectively.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 721afe13ff590122878a8ead62c66f89e8549e91 
>   src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794 
>   src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
>   src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 
>   src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 
> 
> 
> Diff: https://reviews.apache.org/r/71816/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message