mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Date Wed, 08 Jan 2020 16:00:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71971/
-----------------------------------------------------------

(Updated Jan. 8, 2020, 4 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Move dot in comment and add new special case.


Repository: mesos


Description
-------

Added a special case for the `[[deprecated]]` attribute to
handle configurations where clang claims to support this
attribute but also emits a warning that it should not be used.


Diffs (updated)
-----

  3rdparty/stout/include/stout/attributes.hpp 54d438dca56d5346c58eb28eaeda7916a3a62076 


Diff: https://reviews.apache.org/r/71971/diff/2/

Changes: https://reviews.apache.org/r/71971/diff/1-2/


Testing (updated)
-------

Internal CI run.


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message