mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71538: Allowed disabling use of NVML headers.
Date Mon, 06 Jan 2020 14:43:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71538/
-----------------------------------------------------------

(Updated Jan. 6, 2020, 3:43 p.m.)


Review request for mesos, Gilbert Song and Kevin Klues.


Changes
-------

Rename flags, fix issue with cmake-3.16


Bugs: MESOS-9978
    https://issues.apache.org/jira/browse/MESOS-9978


Repository: mesos


Description
-------

NVML is distributed under a license which is probably not "free" which
can e.g., be aan obstacle when including Mesos using symbols from it in
certain distributions.

This patch adds a configure flag to disable use of the NVML headers
completely. Note that with this flag disabled it is impossible to use
GPU isolation with the Mesos containerizer.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 23ef7c1e5c6fe1555b6f2458f2a858471783ae2a 
  3rdparty/Makefile.am 0de005dad9775f9f7e1a77a242e3b345219c7ac3 
  cmake/CompilationConfigure.cmake 089df917d0667b338624459bbcdac433598be304 
  configure.ac 2bf3a34f8e43e22783aff1852094b6232e5e0608 
  docs/configuration/autotools.md 577e79465ebf0d3c3a9b3626ccac15f1fe0aed8f 
  docs/configuration/cmake.md 554c3bf458bc85609225a19ad4843029772ab51c 
  src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a 
  src/Makefile.am 111c156c8a7abc5ece04779e8ac8879a30c22dbf 
  src/slave/containerizer/mesos/containerizer.cpp dd940162b1e44dbdab1773894b2b33a260fdc8da

  src/slave/containerizer/mesos/isolators/gpu/nvml.hpp eb5c0b008abc651d826c399f4538ad8916469b86

  src/slave/containerizer/mesos/isolators/gpu/nvml.cpp 48a5bf6720e5c9a9ceec24740d47c14f0ad097b7

  src/tests/environment.cpp c3596fb94020d2433f15e630516b1320875a9fa3 


Diff: https://reviews.apache.org/r/71538/diff/2/

Changes: https://reviews.apache.org/r/71538/diff/1-2/


Testing
-------

* tested toggle both ways in cmake and autotools build
* wasn't able to test test filter since I don't seem to have access to a dev machine with
GPUs


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message