mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.
Date Fri, 03 Jan 2020 14:12:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71864/
-----------------------------------------------------------

(Updated Jan. 3, 2020, 2:12 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Changes
-------

Fixed formatting in master.cpp


Bugs: MESOS-10023 and MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10023
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

NOTE: This patch also partially addresses MESOS-9562 issue
by modifying the logic of authorizing UNRESERVE operations.
Now, if some reservations have no principal, both authorization of
UNRESERVE_RESOURCES for ANY object and authorizations for unreserving
all reservations that have principals will be requested.


Diffs (updated)
-----

  src/master/authorization.hpp PRE-CREATION 
  src/master/authorization.cpp PRE-CREATION 
  src/master/http.cpp 72587bf054e413402ebf4c6ff8060f7ca8ffcf1b 
  src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483 
  src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 


Diff: https://reviews.apache.org/r/71864/diff/3/

Changes: https://reviews.apache.org/r/71864/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message