mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.
Date Thu, 02 Jan 2020 20:00:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71859/
-----------------------------------------------------------

(Updated Jan. 2, 2020, 8 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Bugs: MESOS-10023 and MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10023
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

This is the first patch in the chain that extract Master code
generating Action-Object pairs into a dedicated ActionObject class,
thus seperating authz Object creation from feeding them into authorizer.

This is a prerequisite to using ObjectApprover interface for
synchronous authorization of Scheduler API calls.


Diffs (updated)
-----

  src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a 
  src/Makefile.am 111c156c8a7abc5ece04779e8ac8879a30c22dbf 
  src/master/authorization.hpp PRE-CREATION 
  src/master/authorization.cpp PRE-CREATION 
  src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483 
  src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 


Diff: https://reviews.apache.org/r/71859/diff/3/

Changes: https://reviews.apache.org/r/71859/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message