From reviews-return-90481-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Nov 27 00:15:01 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id C31AB19FF4 for ; Wed, 27 Nov 2019 00:15:00 +0000 (UTC) Received: (qmail 85165 invoked by uid 500); 27 Nov 2019 00:15:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 85139 invoked by uid 500); 27 Nov 2019 00:15:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 85118 invoked by uid 99); 27 Nov 2019 00:14:59 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2019 00:14:59 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4E42E29D3; Wed, 27 Nov 2019 00:14:58 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 844D4C4016B; Wed, 27 Nov 2019 00:14:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3897775280690954968==" MIME-Version: 1.0 Subject: Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper. From: Greg Mann To: Greg Mann , Benjamin Mahler , Till Toenshoff , Benno Evers Cc: Joseph Wu , mesos Date: Wed, 27 Nov 2019 00:14:58 -0000 Message-ID: <20191127001458.29055.15517@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71664/ X-Sender: Greg Mann References: <20191119201639.600.9779@reviews-vm2.apache.org> In-Reply-To: <20191119201639.600.9779@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============3897775280690954968== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218806 ----------------------------------------------------------- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 218-236 (patched) Do we need these? How can we gain some confidence regarding which control commands need to be supported by our custom BIO and which do not? - Greg Mann On Nov. 19, 2019, 8:16 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71664/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2019, 8:16 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > ------- > > This implements the OpenSSL basic I/O abstraction based on the > libprocess event loop. This BIO wraps a socket and handles the > reading/writing, using io::read and io::write. > > This BIO can be passed into an SSL context to enable usage of > SSL translation functions like SSL_read and SSL_write. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71664/diff/3/ > > > Testing > ------- > > cmake --build . --target process > > A tiny bit of testing next patch. > > > Thanks, > > Joseph Wu > > --===============3897775280690954968==--