From reviews-return-90394-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Nov 19 22:48:22 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 6B0BA198ED for ; Tue, 19 Nov 2019 22:48:22 +0000 (UTC) Received: (qmail 54386 invoked by uid 500); 19 Nov 2019 22:48:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 54359 invoked by uid 500); 19 Nov 2019 22:48:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54325 invoked by uid 99); 19 Nov 2019 22:48:21 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 22:48:21 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D751E2BE9; Tue, 19 Nov 2019 22:48:20 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 34D37C401EC; Tue, 19 Nov 2019 22:48:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8428309464018669432==" MIME-Version: 1.0 Subject: Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown. From: Mesos Reviewbot To: Greg Mann , Benjamin Mahler , Till Toenshoff , Benno Evers Cc: Mesos Reviewbot , Joseph Wu , mesos Date: Tue, 19 Nov 2019 22:48:19 -0000 Message-ID: <20191119224819.64881.13701@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71666/ X-Sender: Mesos Reviewbot References: <20191111194127.61126.79881@reviews-vm2.apache.org> In-Reply-To: <20191111194127.61126.79881@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/ssl/socket_wrapper.hpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============8428309464018669432== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/#review218700 ----------------------------------------------------------- Bad review! Reviews applied: [71666, 71665, 71664, 71663, 71662, 71661, 71660, 71764, 71659] Error: 2019-11-19 22:48:17 URL:https://reviews.apache.org/r/71665/diff/raw/ [16358/16358] -> "71665.patch" [1] error: patch failed: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp:30 error: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp: patch does not apply - Mesos Reviewbot On Nov. 11, 2019, 7:41 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71666/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2019, 7:41 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-10010 > https://issues.apache.org/jira/browse/MESOS-10010 > > > Repository: mesos > > > Description > ------- > > This completes a fully functional client-side SSL socket. > > Needs a bit of cleanup and more error handling though. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71666/diff/5/ > > > Testing > ------- > > ``` > cmake --build . --target libprocess-tests > libprocess-tests > ``` > > Running libprocess-tests yields: > ``` > [ FAILED ] SSLTest.ValidDowngrade > [ FAILED ] SSLTest.ValidDowngradeEachProtocol > [ FAILED ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = "SSL" > [ FAILED ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL" > ``` > > > Thanks, > > Joseph Wu > > --===============8428309464018669432==--