From reviews-return-90390-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Nov 19 20:16:41 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 15AB519205 for ; Tue, 19 Nov 2019 20:16:41 +0000 (UTC) Received: (qmail 93123 invoked by uid 500); 19 Nov 2019 20:16:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93100 invoked by uid 500); 19 Nov 2019 20:16:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93079 invoked by uid 99); 19 Nov 2019 20:16:39 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 20:16:39 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 598E5E2BE9; Tue, 19 Nov 2019 20:16:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1C792C401EC; Tue, 19 Nov 2019 20:16:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1381600468820340099==" MIME-Version: 1.0 Subject: Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper. From: Joseph Wu To: Greg Mann , Benjamin Mahler , Till Toenshoff , Benno Evers Cc: Joseph Wu , mesos Date: Tue, 19 Nov 2019 20:16:39 -0000 Message-ID: <20191119201639.600.9779@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71664/ X-Sender: Joseph Wu References: <20191031012957.13306.79359@reviews-vm2.apache.org> In-Reply-To: <20191031012957.13306.79359@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============1381600468820340099== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ ----------------------------------------------------------- (Updated Nov. 19, 2019, 12:16 p.m.) Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff. Changes ------- Removed blocking `BIO_flush`, and addressed comments about BIO_METHOD creation. Bugs: MESOS-10009 https://issues.apache.org/jira/browse/MESOS-10009 Repository: mesos Description ------- This implements the OpenSSL basic I/O abstraction based on the libprocess event loop. This BIO wraps a socket and handles the reading/writing, using io::read and io::write. This BIO can be passed into an SSL context to enable usage of SSL translation functions like SSL_read and SSL_write. Diffs (updated) ----- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION Diff: https://reviews.apache.org/r/71664/diff/3/ Changes: https://reviews.apache.org/r/71664/diff/2-3/ Testing ------- cmake --build . --target process A tiny bit of testing next patch. Thanks, Joseph Wu --===============1381600468820340099==--