From reviews-return-90301-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Nov 6 13:09:02 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 3494610B01 for ; Wed, 6 Nov 2019 13:09:02 +0000 (UTC) Received: (qmail 97418 invoked by uid 500); 6 Nov 2019 13:09:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 97374 invoked by uid 500); 6 Nov 2019 13:09:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 97182 invoked by uid 99); 6 Nov 2019 13:09:00 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2019 13:09:00 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69BBDE0334; Wed, 6 Nov 2019 13:08:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 541E2C40089; Wed, 6 Nov 2019 13:08:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1216470837026477494==" MIME-Version: 1.0 Subject: Re: Review Request 71725: Added end-to-end test for operator API reservation updates. From: Benjamin Bannier To: Benjamin Bannier Cc: Benno Evers , mesos Date: Wed, 06 Nov 2019 13:08:59 -0000 Message-ID: <20191106130859.34986.65862@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71725/ X-Sender: Benjamin Bannier X-ReviewBoard-ShipIt: 1 References: <20191106110955.34987.35859@reviews-vm2.apache.org> In-Reply-To: <20191106110955.34987.35859@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============1216470837026477494== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/#review218537 ----------------------------------------------------------- Fix it, then Ship it! Nice approach to make the "meat" of the test more obvious through helpers. src/tests/api_tests.cpp Lines 1491 (patched) Stray spaces src/tests/api_tests.cpp Lines 1519 (patched) Nit: to more match the usage we could define this before `verifyReservation`. src/tests/api_tests.cpp Lines 1521 (patched) We could name this `resources` for symmetry. src/tests/api_tests.cpp Lines 1553 (patched) Line too long - Benjamin Bannier On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71725/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2019, 12:09 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Added a new test to verify that reservations can be updated > using the operator API. > > > Diffs > ----- > > src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a > > > Diff: https://reviews.apache.org/r/71725/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > > --===============1216470837026477494==--