mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71661: Added missing header guards for poll_socket.hpp.
Date Mon, 25 Nov 2019 23:36:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71661/#review218796
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.hpp
Lines 13-14 (patched)
<https://reviews.apache.org/r/71661/#comment306664>

    Could we prefix this with `PROCESS_`? We do that in some files (see semaphore.hpp, for
example) to disambiguate libprocess headers from others.
    
    ```
    #ifndef __PROCESS_POLL_SOCKET__
    #define __PROCESS_POLL_SOCKET__
    ```


- Greg Mann


On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71661/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2019, 7:37 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-10009
>     https://issues.apache.org/jira/browse/MESOS-10009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/poll_socket.hpp 881dab1da4f8dfa7826d82398a989fd23cc2262e 
> 
> 
> Diff: https://reviews.apache.org/r/71661/diff/1/
> 
> 
> Testing
> -------
> 
> cmake --build . --target process
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message