mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71805: Fixed memory leak in openssl verification function.
Date Fri, 22 Nov 2019 22:53:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71805/
-----------------------------------------------------------

(Updated Nov. 22, 2019, 10:53 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.


Bugs: MESOS-10041
    https://issues.apache.org/jira/browse/MESOS-10041


Repository: mesos


Description
-------

When the hostname validation scheme was set to 'openssl',
the `openssl::verify()` function would return without
freeing a previously allocated `X509*` object.

To fix the leak, a long-standing TODO to switch to
RAII-based memory management for the certificate was
resolved.


Diffs
-----

  3rdparty/libprocess/src/openssl.cpp bd05866950e1043d9585a7c5fdc7b2147a233fd3 


Diff: https://reviews.apache.org/r/71805/diff/1/


Testing
-------

`make check`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message