mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered
Date Fri, 22 Nov 2019 20:00:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/
-----------------------------------------------------------

(Updated Nov. 22, 2019, 8 p.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Changes
-------

remove the test no longer applicable in the new scenario


Bugs: MESOS-10032
    https://issues.apache.org/jira/browse/MESOS-10032


Repository: mesos


Description
-------

In the case agents lost ZooKeeper connections and resetting its
master to none and beginning to dropping control messages from the
master, agent should not respond pings from master.


Diffs (updated)
-----

  src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 
  src/tests/slave_recovery_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8 


Diff: https://reviews.apache.org/r/71742/diff/4/

Changes: https://reviews.apache.org/r/71742/diff/3-4/


Testing (updated)
-------

make check


Thanks,

Xudong Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message