mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71754: Improved performance of v1 operator API GetState call.
Date Fri, 22 Nov 2019 18:12:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71754/
-----------------------------------------------------------

(Updated Nov. 22, 2019, 6:12 p.m.)


Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.


Changes
-------

* Used NotAcceptable in place of BadRequest
* Added an UNREACHABLE()


Bugs: MESOS-10026
    https://issues.apache.org/jira/browse/MESOS-10026


Repository: mesos


Description (updated)
-------

This follow the same approach used in the GetAgents call;
serializing directly to protobuf or json from the in-memory
v0 state.

Before:
v0 '/state' response took 6.55 secs
v1 'GetState' application/x-protobuf response took 24.08 secs
v1 'GetState' application/json response took 22.76 secs

After:
v0 '/state' response took 8.00 secs
v1 'GetState' application/x-protobuf response took 5.73 secs
v1 'GetState' application/json response took 9.62 secs


Diffs (updated)
-----

  src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df 
  src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f 


Diff: https://reviews.apache.org/r/71754/diff/2/

Changes: https://reviews.apache.org/r/71754/diff/1-2/


Testing (updated)
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message