mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <>
Subject Re: Review Request 71754: Improved performance of v1 operator API GetState call.
Date Fri, 22 Nov 2019 18:12:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 22, 2019, 6:12 p.m.)

Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.


* Used NotAcceptable in place of BadRequest
* Added an UNREACHABLE()

Bugs: MESOS-10026

Repository: mesos

Description (updated)

This follow the same approach used in the GetAgents call;
serializing directly to protobuf or json from the in-memory
v0 state.

v0 '/state' response took 6.55 secs
v1 'GetState' application/x-protobuf response took 24.08 secs
v1 'GetState' application/json response took 22.76 secs

v0 '/state' response took 8.00 secs
v1 'GetState' application/x-protobuf response took 5.73 secs
v1 'GetState' application/json response took 9.62 secs

Diffs (updated)

  src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df 
  src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f 



Testing (updated)

make check


Benjamin Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message