mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71741: Updated operator API documention to use rereservation format.
Date Fri, 22 Nov 2019 11:55:38 GMT


> On Nov. 20, 2019, 3:41 p.m., Benno Evers wrote:
> > docs/operator-http-api.md
> > Line 1870 (original), 1872 (patched)
> > <https://reviews.apache.org/r/71741/diff/2/?file=2174609#file2174609line1872>
> >
> >     Maybe ask a native speaker for a second opinion, but "takes" sounds a bit weird
to me. Maybe "accepts parameters"?
> >     
> >     Also, I would propose adding a short summary of what the call *does* with these
parameters, instead of launching straight into backwards compatibility exceptions, something
like 
> >     
> >     ```
> >     [...] and the target resources, and updates the reservations of `source` to
be equal to the reservations of `target`.
> >     ```

`takes` was used by a couple of native speakers in this doc and looks fine to me.

Thanks for the suggestion on describing effects, updated the doc.


> On Nov. 20, 2019, 3:41 p.m., Benno Evers wrote:
> > docs/operator-http-api.md
> > Lines 1956 (patched)
> > <https://reviews.apache.org/r/71741/diff/2/?file=2174609#file2174609line1956>
> >
> >     Mentioning "multiple levels" here feels a bit like an implementation detail;
from a users perspective we simply allow changing one role to another. (also "levels" are
not present in this example anyways.)

Good point. Dropping this whole sentence as we now already already above call out the requirement
for `source` and `resources` to be identical apart from reservations.


> On Nov. 20, 2019, 3:41 p.m., Benno Evers wrote:
> > docs/operator-http-api.md
> > Lines 1957 (patched)
> > <https://reviews.apache.org/r/71741/diff/2/?file=2174609#file2174609line1957>
> >
> >     s/fall/for/

Sentence was removed.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71741/#review218721
-----------------------------------------------------------


On Nov. 22, 2019, 12:55 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71741/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2019, 12:55 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9993
>     https://issues.apache.org/jira/browse/MESOS-9993
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated operator API documention to use rereservation format.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c 
> 
> 
> Diff: https://reviews.apache.org/r/71741/diff/3/
> 
> 
> Testing
> -------
> 
> Previewed in generated site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message