-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71755/#review218719
-----------------------------------------------------------
Fix it, then Ship it!
Overall looks good to me (and probably this one is more permanent than 71750-71754, as the
metrcis have a simple strictire which is not likely to change, I'd guess).
Do you have any results of benchmarking v1::GetMetrics before/after this vs /metrics/snapshot
?
src/master/http.cpp
Lines 2269 (patched)
<https://reviews.apache.org/r/71755/#comment306595>
s/_getMetrics/getMetrics/ in this comment (and also in serializeGetMetrics)?
src/master/http.cpp
Lines 2274-2277 (patched)
<https://reviews.apache.org/r/71755/#comment306579>
Maybe move this comment right before the declaration of `jsonifyGetMetrics()`? After all,
the statement that the returned `std::fuction` should not outlive `metrics` is an interface
convention, not just an implementation detail.
Alternatively, this can be placed inside of `getMetrics()` as a lambda, which would make
this comment unnecessary (we don't call `jsonifyGetMetrics` from anywhere else, do we?)
src/master/http.cpp
Lines 2446 (patched)
<https://reviews.apache.org/r/71755/#comment306596>
See https://reviews.apache.org/r/71750/
- Andrei Sekretenko
On Nov. 19, 2019, 7:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71755/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2019, 7:43 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
>
>
> Bugs: MESOS-10026
> https://issues.apache.org/jira/browse/MESOS-10026
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follow the same approach used in the GetAgents call;
> serializing directly to protobuf or json from the in-memory
> v0 state.
>
>
> Diffs
> -----
>
> src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
>
>
> Diff: https://reviews.apache.org/r/71755/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Mahler
>
>
|