mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71785: Removed check when validating reservations.
Date Wed, 20 Nov 2019 13:04:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71785/#review218718
-----------------------------------------------------------


Ship it!




Like discussed offline, let's add a test as part of https://reviews.apache.org/r/71787/ which
validates that a persistent volume cannot be unreserved through `RESERVE_RESOURCES` calls.

- Benjamin Bannier


On Nov. 19, 2019, 5:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71785/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2019, 5:52 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed a validation that was checking that `RESERVE` operations
> did not contain disk resources, based on the theory that disk
> resources must already be reserved.
> 
> This assumption does not hold up in the presence of reservation
> updates, so it is removed.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp c5fbbdd55e4a217c756e2ece3f8fd6ed5e88048f 
> 
> 
> Diff: https://reviews.apache.org/r/71785/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message