-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218700
-----------------------------------------------------------
Bad review!
Reviews applied: [71666, 71665, 71664, 71663, 71662, 71661, 71660, 71764, 71659]
Error:
2019-11-19 22:48:17 URL:https://reviews.apache.org/r/71665/diff/raw/ [16358/16358] -> "71665.patch"
[1]
error: patch failed: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp:30
error: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp: patch does not apply
- Mesos Reviewbot
On Nov. 11, 2019, 7:41 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2019, 7:41 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This completes a fully functional client-side SSL socket.
>
> Needs a bit of cleanup and more error handling though.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION
> 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71666/diff/5/
>
>
> Testing
> -------
>
> ```
> cmake --build . --target libprocess-tests
> libprocess-tests
> ```
>
> Running libprocess-tests yields:
> ```
> [ FAILED ] SSLTest.ValidDowngrade
> [ FAILED ] SSLTest.ValidDowngradeEachProtocol
> [ FAILED ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = "SSL"
> [ FAILED ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
|