mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71749: Added a test for AsV1Protobuf.
Date Tue, 19 Nov 2019 17:28:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71749/#review218677
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/common/http_tests.cpp
Lines 269 (patched)
<https://reviews.apache.org/r/71749/#comment306543>

    How about covering nested MESSAGE (repeated and map/non-repeated) and repeated ENUM? (see
my comment in r71748)
    
    Not sure if we have all of those in our protobufs (adding a new `.proto` file for this
test would be an overkill IMO), but at least we have a repeated-message-inside-nested with
a `slave_id` in `scheduler::Call` (`Call::ReconcileOperations`).


- Andrei Sekretenko


On Nov. 11, 2019, 11:59 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71749/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2019, 11:59 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
> 
> 
> Bugs: MESOS-10026
>     https://issues.apache.org/jira/browse/MESOS-10026
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for AsV1Protobuf.
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 51c809d70d364530b4c7845f9382610c2eeef366 
> 
> 
> Diff: https://reviews.apache.org/r/71749/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message