mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.
Date Tue, 19 Nov 2019 13:28:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71664/#review218661
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/ssl/socket_wrapper.cpp
Lines 44 (patched)
<https://reviews.apache.org/r/71664/#comment306518>

    We can replace the 57 by `BIO_get_new_index()` to avoid the conflict with libevent. (Even
if we can't for some reason, we should at least choose 58 here to avoid conflict.)



3rdparty/libprocess/src/ssl/socket_wrapper.cpp
Lines 83 (patched)
<https://reviews.apache.org/r/71664/#comment306519>

    It seems like `synchronized()` for atomic flags is implemented as a busy wait, was this
choice intentional?



3rdparty/libprocess/src/ssl/socket_wrapper.cpp
Lines 258 (patched)
<https://reviews.apache.org/r/71664/#comment306538>

    Should this be `get_libprocess_BIO_METHOD()` for consistency?


- Benno Evers


On Oct. 31, 2019, 1:29 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71664/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2019, 1:29 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-10009
>     https://issues.apache.org/jira/browse/MESOS-10009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This implements the OpenSSL basic I/O abstraction based on the
> libprocess event loop.  This BIO wraps a socket and handles the
> reading/writing, using io::read and io::write.
> 
> This BIO can be passed into an SSL context to enable usage of
> SSL translation functions like SSL_read and SSL_write.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71664/diff/2/
> 
> 
> Testing
> -------
> 
> cmake --build . --target process
> 
> A tiny bit of testing next patch.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message