mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71741: Updated operator API documention to use rereservation format.
Date Mon, 18 Nov 2019 16:41:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71741/#review218664
-----------------------------------------------------------



I'm not sure that this example does much to explain the semantics of the `RESERVE_RESOURCES`
call to unsuspecting readers: The example you modify will behave exactly the same whether
the `source` field is present or not.

At the very least, `source` should be formally introduced in the description of the `RESERVE_RESOURCES`
call at the beginning of the section. Ideally, we'd have a first example without `source`
(i.e. the one we had before) and then a second example using `source` to do an actual reservation
update. (In your commit message you use the word `rereservation`, do we use that anywhere
else?)

- Benno Evers


On Nov. 8, 2019, 1:13 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71741/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2019, 1:13 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9993
>     https://issues.apache.org/jira/browse/MESOS-9993
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated operator API documention to use rereservation format.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c 
> 
> 
> Diff: https://reviews.apache.org/r/71741/diff/1/
> 
> 
> Testing
> -------
> 
> Previewed in generated site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message