mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.
Date Mon, 18 Nov 2019 13:11:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71663/#review218660
-----------------------------------------------------------


Ship it!




Ship It!

- Benno Evers


On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71663/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2019, 7:37 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-10009
>     https://issues.apache.org/jira/browse/MESOS-10009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Depending on the version of OpenSSL and what headers of OpenSSL
> are included, the order of certain Windows headers may be included
> in the "wrong" order.  This results in hundreds of cryptic syntax
> errors from MSVC.
> 
> This sweeps through the existing sites with OpenSSL headers and
> makes sure to include the Windows headers above them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/jwt.hpp 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6

>   3rdparty/libprocess/include/process/ssl/gtest.hpp 4a14a8ef7937e8c6adf3a78db3e9558333700a1b

>   3rdparty/libprocess/include/process/ssl/tls_config.hpp 18c51a8baabf07143c7892dbee0ad2d856457d8d

>   3rdparty/libprocess/src/openssl.cpp bd05866950e1043d9585a7c5fdc7b2147a233fd3 
>   3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48

> 
> 
> Diff: https://reviews.apache.org/r/71663/diff/2/
> 
> 
> Testing
> -------
> 
> cmake --build . (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message