mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71729: Added authorization handling for reservations with `source`.
Date Fri, 08 Nov 2019 12:48:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71729/
-----------------------------------------------------------

(Updated Nov. 8, 2019, 1:48 p.m.)


Review request for mesos and Benno Evers.


Bugs: MESOS-9991
    https://issues.apache.org/jira/browse/MESOS-9991


Repository: mesos


Description
-------

This patch adds authorization handling for `RESERVE` operations
containing `source` fields. In order to stay backwards-compatible we add
a dedicated authorization branch for such operations which under the
hood translates each removed reservation to an `UNRESERVE` operation and
every added reservation as a `RESERVE` operation where we fall back to
existing authorization code for authorization.


Diffs (updated)
-----

  src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d 
  src/tests/master_authorization_tests.cpp 06471aa7779d399f4474ed40db3fbcc60b8298b2 


Diff: https://reviews.apache.org/r/71729/diff/3/

Changes: https://reviews.apache.org/r/71729/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message