mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71725: Added end-to-end test for operator API reservation updates.
Date Wed, 06 Nov 2019 13:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218537
-----------------------------------------------------------


Fix it, then Ship it!




Nice approach to make the "meat" of the test more obvious through helpers.


src/tests/api_tests.cpp
Lines 1491 (patched)
<https://reviews.apache.org/r/71725/#comment306271>

    Stray spaces



src/tests/api_tests.cpp
Lines 1519 (patched)
<https://reviews.apache.org/r/71725/#comment306273>

    Nit: to more match the usage we could define this before `verifyReservation`.



src/tests/api_tests.cpp
Lines 1521 (patched)
<https://reviews.apache.org/r/71725/#comment306274>

    We could name this `resources` for symmetry.



src/tests/api_tests.cpp
Lines 1553 (patched)
<https://reviews.apache.org/r/71725/#comment306272>

    Line too long


- Benjamin Bannier


On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2019, 12:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new test to verify that reservations can be updated
> using the operator API.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a 
> 
> 
> Diff: https://reviews.apache.org/r/71725/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message