mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 71732: Fixed an incorrect resource mutation.
Date Wed, 06 Nov 2019 12:54:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/
-----------------------------------------------------------

Review request for mesos, Benno Evers and Greg Mann.


Repository: mesos


Description
-------

`Resources::pushReservation` does not mutate the `Resources` it is
invoked on; instead it returns its result which should then be used.

This issue was identified by making `Resources::pushReservation`
`nodiscard`.


Diffs
-----

  src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed 


Diff: https://reviews.apache.org/r/71732/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message