From reviews-return-90160-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 17 07:16:02 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 6A1DD19872 for ; Thu, 17 Oct 2019 07:16:02 +0000 (UTC) Received: (qmail 91844 invoked by uid 500); 17 Oct 2019 07:16:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91826 invoked by uid 500); 17 Oct 2019 07:16:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91809 invoked by uid 99); 17 Oct 2019 07:16:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2019 07:16:01 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA8F2E2F4F; Thu, 17 Oct 2019 07:15:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 02AADC40284; Thu, 17 Oct 2019 07:15:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8935965216054418556==" MIME-Version: 1.0 Subject: Re: Review Request 71608: Supported destroying UCR container in `PROVISIONING` state. From: Qian Zhang To: Mesos Reviewbot , Qian Zhang , mesos Date: Thu, 17 Oct 2019 07:15:59 -0000 Message-ID: <20191017071559.3778.56516@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71608/ X-Sender: Qian Zhang References: <20191016134306.37054.60706@reviews-vm2.apache.org> In-Reply-To: <20191016134306.37054.60706@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============8935965216054418556== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71608/ ----------------------------------------------------------- (Updated Oct. 17, 2019, 3:15 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-9964 https://issues.apache.org/jira/browse/MESOS-9964 Repository: mesos Description ------- Previously in MESOS-3736, we made Docker store support pulling same image simultaneously which is a performance improvement, however it may cause an issue: If the pulling hangs somehow, all the subsequent pulling request for the same image will hang as well, and as a result the container destroy will also hang since destroy has to wait for provisioning to finish, see MESOS-4985 for details. So in this patch we removed that performance improvement and made UCR can destroy the container which is being provisioned, i.e., UCR will discard the container provisioning and then keep doing the container destroy. And we also improved Docker fetcher plugin so that when container provisioning is discarded the `curl` process used to fetch manifest or blob will be killed immediately. Diffs (updated) ----- src/slave/containerizer/mesos/containerizer.hpp 6537f6550b353b1c65a30381f6d68f61508d4960 src/slave/containerizer/mesos/containerizer.cpp c61b954635ebcaed3e498452bddeee6e1b34f388 src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 src/slave/containerizer/mesos/provisioner/provisioner.hpp 38664177ae3805041b412ed52dd0134a6f3aa679 src/slave/containerizer/mesos/provisioner/provisioner.cpp 3d0b291fa878ab22625435afe2a219d6f776e52c src/tests/containerizer/mesos_containerizer_tests.cpp 449928c10b897061642af8ad267f8b70695940e6 src/tests/containerizer/provisioner_docker_tests.cpp 5d5a355afd9c4fda1c653d6cecb75703b0f2222e src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 Diff: https://reviews.apache.org/r/71608/diff/5/ Changes: https://reviews.apache.org/r/71608/diff/4-5/ Testing ------- Thanks, Qian Zhang --===============8935965216054418556==--