From reviews-return-90132-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Oct 7 09:24:22 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 14388100B7 for ; Mon, 7 Oct 2019 09:24:21 +0000 (UTC) Received: (qmail 86884 invoked by uid 500); 7 Oct 2019 09:24:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86869 invoked by uid 500); 7 Oct 2019 09:24:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86852 invoked by uid 99); 7 Oct 2019 09:24:21 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Oct 2019 09:24:21 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A52AE005D; Mon, 7 Oct 2019 09:24:20 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 46759C400AE; Mon, 7 Oct 2019 09:24:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3045149407994264034==" MIME-Version: 1.0 Subject: Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors. From: Mesos Reviewbot To: Meng Zhu , Benjamin Mahler Cc: Mesos Reviewbot , Andrei Sekretenko , mesos Date: Mon, 07 Oct 2019 09:24:20 -0000 Message-ID: <20191007092420.54374.98774@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71498/ X-Sender: Mesos Reviewbot References: <20190918125913.38752.46822@reviews-vm2.apache.org> In-Reply-To: <20190918125913.38752.46822@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3045149407994264034== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review218108 ----------------------------------------------------------- Patch looks great! Reviews applied: [71486, 71487, 71488, 71489, 71490, 71491, 71498] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 18, 2019, 12:59 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71498/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 12:59 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Introduced a role tree helper to modify a role and all its ancestors. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp 5ea37912dadded47eaa2d354889c95533b191c59 > src/master/allocator/mesos/hierarchical.cpp 256fdce61ccfb768605cac1579c9a6632cd26fec > > > Diff: https://reviews.apache.org/r/71498/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > > --===============3045149407994264034==--