mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71688: Reject operator API calls that include reservation updates.
Date Wed, 30 Oct 2019 13:39:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71688/#review218458
-----------------------------------------------------------




src/master/http.cpp
Lines 2008-2009 (patched)
<https://reviews.apache.org/r/71688/#comment306185>

    nit: fits on a single line.



src/master/http.cpp
Lines 2015 (patched)
<https://reviews.apache.org/r/71688/#comment306184>

    nit: `!source.empty()`.


- Benjamin Bannier


On Oct. 29, 2019, 7:14 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71688/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2019, 7:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reject operator API calls that include reservation updates.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da 
> 
> 
> Diff: https://reviews.apache.org/r/71688/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message