mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.
Date Thu, 24 Oct 2019 01:41:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71660/
-----------------------------------------------------------

(Updated Oct. 23, 2019, 6:41 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Changes
-------

Removed the `listen` override, since we can just use the PollSocket's implementation here.


Bugs: MESOS-10009
    https://issues.apache.org/jira/browse/MESOS-10009


Repository: mesos


Description
-------

This creates some new files implementing the SocketImpl class,
in preparation for implementing generic SSL sockets.

The new class is used whenever SSL is enabled, but Libevent is not.


Diffs (updated)
-----

  3rdparty/libprocess/src/CMakeLists.txt 40c8ef935104bab4ea2f8b2b5919450b55165f60 
  3rdparty/libprocess/src/openssl.cpp bd05866950e1043d9585a7c5fdc7b2147a233fd3 
  3rdparty/libprocess/src/socket.cpp 606a1c46e50936251c29af4b996007c480b2a135 
  3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71660/diff/2/

Changes: https://reviews.apache.org/r/71660/diff/1-2/


Testing
-------

cmake .. -ENABLE_SSL=1   # No Libevent here!


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message