mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 71652: Avoid double reaping race in the command executor.
Date Wed, 23 Oct 2019 14:23:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71652/#review218354
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Oct. 23, 2019, 3:52 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71652/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2019, 3:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-10007
>     https://issues.apache.org/jira/browse/MESOS-10007
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, it was possible for the command executor to miss
> the exit status of the subprocess since it performs its own
> reap and doesn't use the Subprocess::status. See MESOS-10007.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp d9b39e5a66eb7bc739dede52f43da8ca9f7c09d1 
> 
> 
> Diff: https://reviews.apache.org/r/71652/diff/1/
> 
> 
> Testing
> -------
> 
> make check + manual testing from Charles in JIRA
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message