mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71639: Work-in-progress: Added an benchmark for `UpdateAllocation` call.
Date Mon, 21 Oct 2019 08:18:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71639/#review218301
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71639]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 21, 2019, 5:41 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71639/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2019, 5:41 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Work-in-progress: Added an benchmark for `UpdateAllocation` call.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 38fd19cee6409e4daa5bb0ab523e8e464cdcc9a5

> 
> 
> Diff: https://reviews.apache.org/r/71639/diff/1/
> 
> 
> Testing
> -------
> 
> On 1.9.x branch:
> 
> A sample update log line:
> 
> ```
> I1020 22:33:58.575657 47739 hierarchical.cpp:1192] Updated allocation of framework framework11
on agent agent1 from mem(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations:
[(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label: bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):128;
cpus(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations: [(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label:
bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):1; disk(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations:
[(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label: bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):128
to mem(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):128; cpus(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):1;
disk(allocated: loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):128
> ```
> 
> ```
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 235.456896ms
> Each reserve and unreserve pair operation takes 11.772844ms
> [       OK ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/0
(243 ms)
> [ RUN      ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/1
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 118.172514ms
> Each reserve and unreserve pair operation takes 5.908625ms
> [       OK ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/1
(122 ms)
> [ RUN      ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/2
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 232.310825ms
> Each reserve and unreserve pair operation takes 11.615541ms
> [       OK ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/2
(237 ms)
> [ RUN      ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/3
> Agent resources size: 400
> Made 20 reserve and unreserve operations in 2.479472164secs
> Each reserve and unreserve pair operation takes 123.973608ms
> [       OK ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/3
(2558 ms)
> [ RUN      ] ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/4
> Agent resources size: 400
> Made 20 reserve and unreserve operations in 4.651083637secs
> Each reserve and unreserve pair operation takes 232.554181ms
> ```
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message