mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71599: Added validation against scalar overflow.
Date Wed, 09 Oct 2019 07:19:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71599/#review218151
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71595, 71596, 71597, 71598, 71599]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 9, 2019, 4:43 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71599/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2019, 4:43 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that this input scalar validation is currently used during quota
> validation as well as during parsing. This means resources passed as
> strings will now include this overflow validation.
> 
> This validation is insufficient, it's still possible to use a very
> large value close to the overflow point, and have some addition occur
> later leading to overflow and a crash. But, it's better than nothing.
> 
> 
> Diffs
> -----
> 
>   src/common/validation.cpp 14a8c7b9d70c303b527e5e43012999471ced2d78 
>   src/common/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660 
>   src/v1/values.cpp 6193dbd8bad7f060e6bb2c18e3984c4a4b061ab6 
> 
> 
> Diff: https://reviews.apache.org/r/71599/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message