mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.
Date Fri, 04 Oct 2019 18:23:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review218082
-----------------------------------------------------------



Bad review!

Reviews applied: [71498, 71491, 71490, 71489, 71488, 71487, 71486]

Error:
2019-10-04 18:23:53 URL:https://reviews.apache.org/r/71488/diff/raw/ [6554/6554] -> "71488.patch"
[1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1477
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

- Mesos Reviewbot


On Sept. 18, 2019, 12:59 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2019, 12:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 5ea37912dadded47eaa2d354889c95533b191c59

>   src/master/allocator/mesos/hierarchical.cpp 256fdce61ccfb768605cac1579c9a6632cd26fec

> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message