mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71501: Gc'ed nested container sandbox only if we have root container sandbox.
Date Thu, 03 Oct 2019 07:46:59 GMT


> On Sept. 28, 2019, 5:55 a.m., Gilbert Song wrote:
> > I remember we used to fix an similar issue - root container sandbox is not recovered.
could you remind me how could we get into this case?

I think we never recover sandbox for orphan containers (root or nested), see https://github.com/apache/mesos/blob/1.9.0/src/slave/containerizer/mesos/containerizer.hpp#L370:L371
for details.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71501/#review217970
-----------------------------------------------------------


On Sept. 18, 2019, 6:49 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71501/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2019, 6:49 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9966
>     https://issues.apache.org/jira/browse/MESOS-9966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Gc'ed nested container sandbox only if we have root container sandbox.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 16149a1428db687b131de08d14893a2dd684ce28

> 
> 
> Diff: https://reviews.apache.org/r/71501/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message