mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71489: Replaced removal+adding of quota metrics with updating them.
Date Wed, 02 Oct 2019 20:01:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71489/#review218030
-----------------------------------------------------------


Ship it!




Ship It!


src/master/allocator/mesos/metrics.hpp
Lines 116 (patched)
<https://reviews.apache.org/r/71489/#comment305503>

    // We use singular suffix to keep backward compatibility.


- Meng Zhu


On Sept. 17, 2019, 6:35 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71489/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2019, 6:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9123
>     https://issues.apache.org/jira/browse/MESOS-9123
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch factor out the common code for updating quota guarantee
> and quota limit metrics, and replaces pairs of
> `process::metrics::remove()`/`process::metrics::add()` called for the
> same metric with calling `PushGauge::operator = ()`. This is
> a perequisite for adding PushGauge-based quota consumption metrics.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/metrics.hpp adb9515c82029f32e57e73cddd441c1bceec1aee 
>   src/master/allocator/mesos/metrics.cpp ba95dc4415e3f85522f5d1291b6e9c171b900482 
> 
> 
> Diff: https://reviews.apache.org/r/71489/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message