mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id
Date Fri, 25 Oct 2019 06:56:56 GMT
ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for
any task_id
URL: https://github.com/apache/mesos/pull/345#discussion_r338909310
 
 

 ##########
 File path: src/python/cli_new/lib/cli/mesos.py
 ##########
 @@ -169,11 +169,11 @@ def __init__(self, master, task_id):
         # "MESOS". Having a type of "MESOS" implies that it was launched by the
         # UCR -- all other types imply it was not.
         try:
-            tasks = get_tasks(master)
+            tasks = get_tasks(master, query={'task_id': task_id})
         except Exception as exception:
-            raise CLIException("Unable to get tasks from leading"
+            raise CLIException("Unable to get task {task_id} from leading"
 
 Review comment:
   Following the documentation "task_id=VALUE        Only return tasks with this ID (should
be used together with parameter 'framework_id')." in http://mesos.apache.org/documentation/latest/endpoints/master/tasks/,
I would suggest returning the exception `Unable to get tasks with ID {task_id} ...`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message