mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71454: Added `futureTracker` to the `SlaveOptions` in tests.
Date Mon, 23 Sep 2019 02:28:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71454/#review217907
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.cpp
Lines 350 (patched)
<https://reviews.apache.org/r/71454/#comment305280>

    Do you want to implement a `StartSlave` like below for the test `ROOT_ContainerizerDebugEndpoint`
you added in r/71455 to use (so that we do not have to call `withFutureTracker` there)?
    ```
    Try<Owned<cluster::Slave>> MesosTest::StartSlave(
        mesos::master::detector::MasterDetector* detector,
        mesos::PendingFutureTracker* pendingFutureTracker,
        const Option<slave::Flags>& flags)
    {
      return StartSlave(SlaveOptions(detector)
        .withFlags(flags)
        .withPendingFutureTracker(pendingFutureTracker));
    }
    ```


- Qian Zhang


On Sept. 9, 2019, 10:53 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71454/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2019, 10:53 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9843
>     https://issues.apache.org/jira/browse/MESOS-9843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `PendingFutureTracker` is shared across both Mesos containerizer and
> the agent, so we need to add an option to be able to start a slave in
> tests with an instance of the `futureTrack` as a parameter.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp c04ee14beafe350568a295c8258566aa3704028a 
>   src/tests/cluster.cpp 1646516f1bacc2371eb420f118b656c8c475367c 
>   src/tests/mesos.hpp ecde51828cb74b34d8ee338259e3ece3944a17f1 
>   src/tests/mesos.cpp e77db2231cd81a272c2b7143a48ee193e63e54ab 
> 
> 
> Diff: https://reviews.apache.org/r/71454/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message