mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71441: Fixed URI stringification.
Date Thu, 19 Sep 2019 08:06:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71441/#review217847
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71441]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 5:11 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71441/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-9963
>     https://issues.apache.org/jira/browse/MESOS-9963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the caller is not careful to ensure that the path component begins
> with '/', stringification of URI objects will concatenate the host and
> path, resulting in an malformed URI. The fix is to ensure that these
> fields are always separated by '/'.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_spec_tests.cpp 4be0716895132e0406299f7d77f8ceb2d95dbe8a

>   src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 
>   src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e 
> 
> 
> Diff: https://reviews.apache.org/r/71441/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message