mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71441: Fixed Docker registry malformed URI contruction.
Date Mon, 16 Sep 2019 05:24:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71441/#review217748
-----------------------------------------------------------



In the description of this patch, I see you mentioned we only have this issue with a non-default
Docker registry, but that seems not what I found. I started Mesos agent without setting the
flag `--docker_registry` (so it just took the default value: `https://registry-1.docker.io`)
and then launched a container with an image named `zhq527725/whiteout:latest`, and then I
see:
> Pulling image 'zhq527725/whiteout:latest' from 'docker-manifest://registry-1.docker.io:443zhq527725/whiteout?latest#https'
to '/opt/qzhang/mesos/store/docker/staging/pKccqL'

As you see, the separator between the hostname and the path was missed as well, and I found
the container can be launched successfully. So what is actually the issue? Just the malformed
registry URLs in the above message? If I read MESOS-9963 correctly, the issue should be launching
container fails, right?

- Qian Zhang


On Sept. 6, 2019, 2:20 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71441/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2019, 2:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-9963
>     https://issues.apache.org/jira/browse/MESOS-9963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a non-default Docker registry is used for container image, the Docker
> puller would omit the separator between the hostname and the path when
> constructing the final URI.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_spec_tests.cpp 4be0716895132e0406299f7d77f8ceb2d95dbe8a

>   src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 
>   src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e 
> 
> 
> Diff: https://reviews.apache.org/r/71441/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message