mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.
Date Thu, 12 Sep 2019 09:01:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/
-----------------------------------------------------------

(Updated Sept. 12, 2019, 11:01 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Simplify the test even more


Repository: mesos


Description
-------

The agent might take some time before registering with the master which
could have lead to unexpected retries in this test which the clock was
resumed. This patch simplifies the test so we do not rely on
`UpdateSlaveMessage` anymore.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 089aa9787a66d737267179ad461be0c0a99d5c63



Diff: https://reviews.apache.org/r/71445/diff/2/

Changes: https://reviews.apache.org/r/71445/diff/1-2/


Testing
-------

* `make check`
* ran test fixed here in repetition under external stress. Previous failure rate ~6%, no failures
in >5k runs after


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message