mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69411: Added new interface for constructing `cluster::Master`.
Date Mon, 09 Sep 2019 13:56:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69411/
-----------------------------------------------------------

(Updated Sept. 9, 2019, 1:56 p.m.)


Review request for mesos, Andrei Budnik, Benjamin Bannier, Benjamin Mahler, James Peach, and
Joseph Wu.


Changes
-------

Update review for parity with `SlaveOptions` refactoring.


Repository: mesos


Description (updated)
-------

This review adds a new `struct MasterOptions` and a new overload
`StartMaster(const MasterOptions&)` analogous to the refactoring
done for `SlaveOptions`.

This deprecates the other, existing overloads for `StartMaster()`.


Diffs (updated)
-----

  src/tests/mesos.hpp ecde51828cb74b34d8ee338259e3ece3944a17f1 
  src/tests/mesos.cpp e77db2231cd81a272c2b7143a48ee193e63e54ab 


Diff: https://reviews.apache.org/r/69411/diff/3/

Changes: https://reviews.apache.org/r/69411/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message