mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@d2iq.com>
Subject Re: Review Request 71453: Punctually disabled pylint's `cyclic-import` warning.
Date Mon, 09 Sep 2019 13:56:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71453/#review217649
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On Sept. 9, 2019, 3:54 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71453/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In certain places in the new CLI we reimport symbols into other modules.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/__init__.py e594b30e76056a7c5dd4438da34e9883c7c9bc2c 
>   src/python/cli_new/lib/cli/tests/__init__.py 144cb338e9453c7f68d74a58620ee9d2345e363d

> 
> 
> Diff: https://reviews.apache.org/r/71453/diff/1/
> 
> 
> Testing
> -------
> 
> Before this patch the following test fails,
> 
> ```
> $ cmake .. -DPYTHON_3=python3 -DENABLE_NEW_CLI=ON && make cli-tests &&
ctest -R CLITests
> ...
> 4: py3-lint runtests: commands[0] | pylint --score=n --rcfile=../../../support/pylint.config
lib/cli tests
> 4: ************* Module tests.main
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> cli.plugins.base)
(cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) (cyclic-import)
> 4: ERROR: InvocationError for command '/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint
--score=n --rcfile=../../../support/pylint.config lib/cli tests' (exited with code 8)
> 4: ___________________________________ summary ____________________________________
> 4: ERROR:   py3-lint: commands failed
> 1/1 Test #4: CLITests .........................***Failed    6.02 sec
> 
> 0% tests passed, 1 tests failed out of 1
> 
> Total Test time (real) =   6.03 sec
> 
> The following tests FAILED:
>           4 - CLITests (Failed)
> Errors while running CTest
> ```
> 
> After this patch the test passes,
> 
> ```
> ...
> 4: py3-lint runtests: commands[0] | pylint --score=n --rcfile=../../../support/pylint.config
lib/cli tests
> 4: ___________________________________ summary ____________________________________
> 4:   py3-lint: commands succeeded
> 4:   congratulations :)
> ...
> ```
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message