mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71433: Separated handling offer validation failure from handling success.
Date Fri, 06 Sep 2019 16:50:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71433/
-----------------------------------------------------------

(Updated Sept. 6, 2019, 4:50 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-1452 and MESOS-9949
    https://issues.apache.org/jira/browse/MESOS-1452
    https://issues.apache.org/jira/browse/MESOS-9949


Repository: mesos


Description (updated)
-------

This patch refactors the loop through offer IDs in `Master::accept()`
into two simpler loops: one loop for the offer validation failure case,
another for the case of validation success, thus bringing removal of
offers and recovering their resources close together.

This is a prerequisite for implementing `rescindOffer()`/
`declineOffer()` in the dependent patch.


Diffs (updated)
-----

  src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 


Diff: https://reviews.apache.org/r/71433/diff/2/

Changes: https://reviews.apache.org/r/71433/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message