mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.
Date Fri, 06 Sep 2019 16:14:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/#review217612
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71445]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 6, 2019, 12:39 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71445/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2019, 12:39 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent might take some time before registering with the master which
> could have lead to unexpected retries in this test which the clock was
> resumed. This patch simplifies the test so we do not rely on
> `UpdateSlaveMessage` anymore.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 089aa9787a66d737267179ad461be0c0a99d5c63

> 
> 
> Diff: https://reviews.apache.org/r/71445/diff/1/
> 
> 
> Testing
> -------
> 
> * `make check`
> * ran test fixed here in repetition under external stress. Previous failure rate ~6%,
no failures in >5k runs after
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message