mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 71424: Added `SlaveOptions` for wrapping all parameters of `StartSlave`.
Date Thu, 05 Sep 2019 14:00:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71424/
-----------------------------------------------------------

(Updated Сен. 5, 2019, 2 п.п.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, Gilbert Song, Greg
Mann, James Peach, Joseph Wu, Meng Zhu, Qian Zhang, and Till Toenshoff.


Changes
-------

Added setters for `SlaveOptions` to support "fluent interface".


Bugs: MESOS-9914
    https://issues.apache.org/jira/browse/MESOS-9914


Repository: mesos


Description
-------

This patch introduces a `SlaveOptions` struct which holds optional
parameters accepted by `cluster::Slave::create`. Added an overload
of `StartSlave` that accepts `SlaveOptions`. It's a preferred way of
creating and starting an instance of `cluster::Slave` in tests, since
underlying `cluster::Slave::create` accepts a long list of optional
arguments, which might be extended in the future.


Diffs (updated)
-----

  src/tests/mesos.hpp 25359a24955fbe6413b3354aabf444818b58cb76 
  src/tests/mesos.cpp 0396ce78b13e76cfe2596f0f92ddf9dcccc82fca 


Diff: https://reviews.apache.org/r/71424/diff/2/

Changes: https://reviews.apache.org/r/71424/diff/1-2/


Testing
-------

`make check`


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message