mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71436: Replaced removeOffer + recoverResources pairs with specialized helpers.
Date Thu, 05 Sep 2019 05:55:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71436/#review217575
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71433, 71434, 71435, 71436]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 4, 2019, 5:54 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71436/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2019, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-1452 and MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-1452
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds helper methods `Master::rescindOffer()` /
> `Master::discardOffer()` that recover offer's resources in the allocator
> and remove the offer, and replaces paired calls of `removeOffer()` +
> `allocator->recoverResources()` with these helpers.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 0987d933c03b059c70f0b7c6231df73b8b4d228f 
>   src/master/master.hpp 19c17821d2b8111ebe8e1429a5b4a8423357fdd6 
>   src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 
>   src/master/quota_handler.cpp f28eb27964afd2c8bfa0bf7a3ab8246442812f2a 
>   src/master/weights_handler.cpp dfb6f06449f85e7acb156cac0ff79cadcc712255 
> 
> 
> Diff: https://reviews.apache.org/r/71436/diff/1/
> 
> 
> Testing
> -------
> 
> make check, 10 times
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message