mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71434: Moved `removeOffers()` from `Master::accept()` into `Master::_accept()`.
Date Thu, 05 Sep 2019 00:27:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71434/#review217569
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 4441-4457 (original), 4439-4448 (patched)
<https://reviews.apache.org/r/71434/#comment304844>

    I think it makes more sense to move the metrics down to the `_accept` path, and then we
would no longer need this loop. We could just look at one of the offers (consider to loop
and check they are the same in the validation path above).


- Meng Zhu


On Sept. 4, 2019, 10:53 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71434/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2019, 10:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-1452 and MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-1452
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch moves offer removal on accept into the deferred continuation
> that follows authorization (if offers pass validation in `accept()`).
> 
> This is a prerequisite for implementing `rescindOffer()` /
> `declineOffer()` / in the dependent patch.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 19c17821d2b8111ebe8e1429a5b4a8423357fdd6 
>   src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 
> 
> 
> Diff: https://reviews.apache.org/r/71434/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message