mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71429: Precalculated the master per-framework metrics prefix.
Date Wed, 04 Sep 2019 22:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71429/#review217566
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Sept. 4, 2019, 6:51 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71429/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2019, 6:51 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Andrei Sekretenko, Benjamin Mahler, Greg Mann,
and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than store a copy of the FrameworkInfo and generate the prefix
> in the FrameworkMetrics each time we add metric, generate the prefix
> once and store that.
> 
> 
> Diffs
> -----
> 
>   src/master/metrics.hpp 04fecf2de80dc0f1a2d8b1ef43db57505f6975e4 
>   src/master/metrics.cpp e3c871cfbf1e3b4eeaad0090eae9198b035f875d 
> 
> 
> Diff: https://reviews.apache.org/r/71429/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message