mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71385: Added restart logic for failing resource providers.
Date Wed, 04 Sep 2019 12:42:18 GMT


> On Sept. 3, 2019, 3:28 p.m., Jan Schlicht wrote:
> > src/resource_provider/daemon.cpp
> > Lines 536 (patched)
> > <https://reviews.apache.org/r/71385/diff/1/?file=2163045#file2163045line536>
> >
> >     Should we restart here? Though the future currently won't be set to ready, it
might do that in the future. If a resource provider is exited normally, is it supposed to
be restarted?

Very good point. I fixed the handling to return early if the container exited normally (this
will currently not be triggered as nothing makes the `Future` ready).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/#review217546
-----------------------------------------------------------


On Sept. 4, 2019, 2:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71385/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2019, 2:42 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8400
>     https://issues.apache.org/jira/browse/MESOS-8400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds restart logic to the resource provider daemon. We now
> watch launched providers and restart them should they become terminal.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
>   src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
>   src/resource_provider/storage/provider.hpp ccd09dfe826d89c2775939bf132697956429c289

>   src/resource_provider/storage/provider.cpp 0a8dc26e66db0242474bcbbd0b2ff9cec81c58f5

>   src/tests/storage_local_resource_provider_tests.cpp 089aa9787a66d737267179ad461be0c0a99d5c63

> 
> 
> Diff: https://reviews.apache.org/r/71385/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message