mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 71424: Added `SlaveOptions` for wrapping all parameters of `StartSlave`.
Date Wed, 04 Sep 2019 05:52:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71424/#review217557
-----------------------------------------------------------



How does the options approach look once tou use it at call sites rather than the StartSlave
overloads?

- James Peach


On Sept. 2, 2019, 4:36 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71424/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2019, 4:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, Gilbert Song,
Greg Mann, James Peach, Joseph Wu, Meng Zhu, Qian Zhang, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9914
>     https://issues.apache.org/jira/browse/MESOS-9914
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a `SlaveOptions` struct which holds optional
> parameters accepted by `cluster::Slave::create`. Added an overload
> of `StartSlave` that accepts `SlaveOptions`. It's a preferred way of
> creating and starting an instance of `cluster::Slave` in tests, since
> underlying `cluster::Slave::create` accepts a long list of optional
> arguments, which might be extended in the future.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 25359a24955fbe6413b3354aabf444818b58cb76 
>   src/tests/mesos.cpp 0396ce78b13e76cfe2596f0f92ddf9dcccc82fca 
> 
> 
> Diff: https://reviews.apache.org/r/71424/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message