mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.
Date Tue, 03 Sep 2019 20:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/
-----------------------------------------------------------

(Updated Sept. 3, 2019, 1:49 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Changes
-------

Rebased and updated with benchmark result.


Repository: mesos


Description (updated)
-------

This would simplify the tracking logic regarding
resource allocations in the allocator. See MESOS-9182.

Negligible performance impact:

Master:

BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Added 3000 agents in 77.999483ms
Added 3000 frameworks in 16.736076171secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
with drf sorter
Made 3500 allocations in 15.342376944secs
Made 0 allocation in 13.96720191secs

Master + this patch:

BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Added 3000 agents in 83.597048ms
Added 3000 frameworks in 16.757011745secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
with drf sorter
Made 3500 allocations in 15.566366241secs
Made 0 allocation in 14.022591871secs


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 48ba399e12129b3348b5c43b793f3428acf26d4e 
  src/master/allocator/mesos/hierarchical.cpp 187de173ee2f563e2ff0f7e5c96695dd94a73970 


Diff: https://reviews.apache.org/r/68508/diff/3/

Changes: https://reviews.apache.org/r/68508/diff/2-3/


Testing (updated)
-------

make check
Benchmark result in the description


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message